From b0d8bcd742b375eab1cde56644731b616cf69431 Mon Sep 17 00:00:00 2001
From: retr0volkov <retrds438@gmail.com>
Date: Sat, 5 Sep 2026 14:23:08 +0300
Subject: [PATCH] Converters updated as MarkupExtension

---
 WinWARP.Ui/Converters/ItemInvokedEventArgsConverter.cs | 6 +++++-
 WinWARP.Ui/Converters/LanguageCodeToNameConverter.cs   | 6 +++++-
 WinWARP.Ui/MainWindow.xaml                             | 5 +----
 WinWARP.Ui/Views/SettingsPage.xaml                     | 5 +----
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/WinWARP.Ui/Converters/ItemInvokedEventArgsConverter.cs b/WinWARP.Ui/Converters/ItemInvokedEventArgsConverter.cs
index 4feff7d..8e5366b 100644
--- a/WinWARP.Ui/Converters/ItemInvokedEventArgsConverter.cs
+++ b/WinWARP.Ui/Converters/ItemInvokedEventArgsConverter.cs
@@ -3,11 +3,15 @@ using System.Collections.Generic;
 using System.Text;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Data;
+using Microsoft.UI.Xaml.Markup;
 
 namespace WinWARP.Ui.Converters;
 
-public class ItemInvokedEventArgsConverter : IValueConverter
+[MarkupExtensionReturnType(ReturnType = typeof(IValueConverter))]
+public class ItemInvokedEventArgsConverter : MarkupExtension, IValueConverter
 {
+    protected override object ProvideValue() => this;
+
     public object? Convert(object value, Type targetType, object parameter, string language)
     {
         if (value is NavigationViewItemInvokedEventArgs args)
diff --git a/WinWARP.Ui/Converters/LanguageCodeToNameConverter.cs b/WinWARP.Ui/Converters/LanguageCodeToNameConverter.cs
index a3e69ae..6667d16 100644
--- a/WinWARP.Ui/Converters/LanguageCodeToNameConverter.cs
+++ b/WinWARP.Ui/Converters/LanguageCodeToNameConverter.cs
@@ -3,11 +3,15 @@ using System.Collections.Generic;
 using System.Globalization;
 using System.Text;
 using Microsoft.UI.Xaml.Data;
+using Microsoft.UI.Xaml.Markup;
 
 namespace WinWARP.Ui.Converters;
 
-public class LanguageCodeToNameConverter : IValueConverter
+[MarkupExtensionReturnType(ReturnType = typeof(IValueConverter))]
+public class LanguageCodeToNameConverter : MarkupExtension, IValueConverter
 {
+    protected override object ProvideValue() => this;
+
     public object Convert(object value, Type targetType, object parameter, string language)
     {
         if (value is string languageCode && !string.IsNullOrWhiteSpace(languageCode))
diff --git a/WinWARP.Ui/MainWindow.xaml b/WinWARP.Ui/MainWindow.xaml
index d6caa00..7bf4aeb 100644
--- a/WinWARP.Ui/MainWindow.xaml
+++ b/WinWARP.Ui/MainWindow.xaml
@@ -20,9 +20,6 @@
     </Window.SystemBackdrop>
 
     <Grid x:Name="RootGrid">
-        <Grid.Resources>
-            <conv:ItemInvokedEventArgsConverter x:Key="ItemInvokedEventArgsConverter" />
-        </Grid.Resources>
         <Grid.RowDefinitions>
             <RowDefinition Height="Auto"/>
             <RowDefinition Height="*"/>
@@ -47,7 +44,7 @@
                 <i:EventTriggerBehavior EventName="ItemInvoked">
                     <i:InvokeCommandAction 
                         Command="{x:Bind ViewModel.NavigateCommand}" 
-                        InputConverter="{StaticResource ItemInvokedEventArgsConverter}" />
+                        InputConverter="{conv:ItemInvokedEventArgsConverter}" />
                 </i:EventTriggerBehavior>
             </i:Interaction.Behaviors>
             <NavigationView.MenuItems>
diff --git a/WinWARP.Ui/Views/SettingsPage.xaml b/WinWARP.Ui/Views/SettingsPage.xaml
index a3786fb..5e88803 100644
--- a/WinWARP.Ui/Views/SettingsPage.xaml
+++ b/WinWARP.Ui/Views/SettingsPage.xaml
@@ -15,9 +15,6 @@
 
     <ScrollView>
         <StackPanel Margin="24,14,24,24">
-            <StackPanel.Resources>
-                <conv:LanguageCodeToNameConverter x:Key="LanguageCodeToNameConverter" />
-            </StackPanel.Resources>
             <TextBlock u:Uids.Uid="SettingsPageTitle" Style="{StaticResource TitleTextBlockStyle}" Margin="0,0,0,10"/>
 
             <!--App settings-->
@@ -67,7 +64,7 @@
                 <ComboBox ItemsSource="{x:Bind ViewModel.Languages}" SelectedItem="{x:Bind ViewModel.SelectedLanguage, Mode=TwoWay}">
                     <ComboBox.ItemTemplate>
                         <DataTemplate x:DataType="x:String">
-                            <TextBlock Text="{Binding Converter={StaticResource LanguageCodeToNameConverter}}"/>
+                            <TextBlock Text="{Binding Converter={conv:LanguageCodeToNameConverter}}"/>
                         </DataTemplate>
                     </ComboBox.ItemTemplate>
                 </ComboBox>